Skip to content

Signals: fix dirty git repo after publish #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

Signals: fix dirty git repo after publish #1193

merged 1 commit into from
Nov 19, 2024

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Nov 18, 2024 •
edited
Loading

  • Fix this changing after publish image

  • Ensure in CI that files are committed if they change.

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 3eb6038

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky requested a review from alanjcharles November 18, 2024 20:51
@silesky silesky changed the title fix dirty git repo after publish Signals: fix dirty git repo after publish Nov 18, 2024
@silesky silesky merged commit c95baab into master Nov 19, 2024
7 checks passed
@silesky silesky deleted the fix-signals-generated-dirty-working-dir branch November 19, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danieljackins danieljackins danieljackins approved these changes

+1 more reviewer

@alanjcharles alanjcharles alanjcharles approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@silesky @danieljackins @alanjcharles